Merge lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-with--collect-strace-output-doesnt-go-to-an-YYYY_MM_DD_HH_mm_ss-strace-file-1417558 into lp:~percona-toolkit-dev/percona-toolkit/release-2.2.14

Proposed by Frank Cizmich
Status: Merged
Approved by: Frank Cizmich
Approved revision: 614
Merged at revision: 626
Proposed branch: lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-with--collect-strace-output-doesnt-go-to-an-YYYY_MM_DD_HH_mm_ss-strace-file-1417558
Merge into: lp:~percona-toolkit-dev/percona-toolkit/release-2.2.14
Diff against target: 11 lines (+1/-1)
1 file modified
bin/pt-stalk (+1/-1)
To merge this branch: bzr merge lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-with--collect-strace-output-doesnt-go-to-an-YYYY_MM_DD_HH_mm_ss-strace-file-1417558
Reviewer Review Type Date Requested Status
Percona Toolkit developers Pending
Review via email: mp+255568@code.launchpad.net

Description of the change

bug prevented pt-stalk (when used with --collect-strace) from saving strace data in correct file.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/pt-stalk'
--- bin/pt-stalk 2015-01-23 10:19:56 +0000
+++ bin/pt-stalk 2015-04-08 19:44:45 +0000
@@ -857,7 +857,7 @@
857 have_oprofile="yes"857 have_oprofile="yes"
858 fi858 fi
859 elif [ "$CMD_STRACE" -a "$OPT_COLLECT_STRACE" -a "$mysqld_pid" ]; then859 elif [ "$CMD_STRACE" -a "$OPT_COLLECT_STRACE" -a "$mysqld_pid" ]; then
860 $CMD_STRACE -T -s 0 -f -p $mysqld_pid > "${DEST}/$d-strace" &860 $CMD_STRACE -T -s 0 -f -p $mysqld_pid -o "$d/$p-strace" &
861 local strace_pid=$!861 local strace_pid=$!
862 fi862 fi
863863

Subscribers

People subscribed via source and target branches

to all changes: