Code review comment for lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-2.0

Baron,

These and more should be fixed. Please see http://bazaar.launchpad.net/~percona-toolkit-dev/percona-toolkit/pt-stalk-2.0/revision/188 and http://bazaar.launchpad.net/~percona-toolkit-dev/percona-toolkit/pt-stalk-2.0/revision/189

Le 2 févr. 2012 à 07:05, Baron Schwartz a écrit :

> Review: Needs Fixing
>
> In pt-mext, we have this:
>
> 61 mk_tmpdir
> 62
> 63 FILE=`mktemp -p $TMPDIR mext_temp_file.XXXXXX`;
> 64 NUM=0;
> 65 REL=0;
> 66 rm -f $FILE*;
>
> So we're making a random temp file inside of a directory that's already been randomly made. The problem is, mktemp doesn't have a -p option on all platforms. I would suggest that instead, we hardcode the filename inside the temp directory we made:
>
> mk_tmpdir
> FILE="$TMPDIR/mext_temp_file"
>
> In pt-mysql-summary, should we comment out the "set -u" introduced by the bash lib? I doubt this tool is really ready for this option.
> --
> https://code.launchpad.net/~percona-toolkit-dev/percona-toolkit/pt-stalk-2.0/+merge/91130
> You proposed lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-2.0 for merging.