Merge lp:~percona-toolkit-dev/percona-toolkit/pt-slave-find-add-resolve-address-option-1418446 into lp:~percona-toolkit-dev/percona-toolkit/release-2.2.14

[Frank Cizmich]

In response to feature request:

Adds option --resolve-address to pt-slave-find.
This makes the tool resolve the IP address of the server to a hostname and print it out within parenthesis alongside the IP.

Example:

127.0.0.1:12345 (db1.sample.net)
+- 127.0.0.1:12346 (db2.sample.net)
   +- 127.0.0.1:12347 (db3.sample.net)

Off by default

[Daniel Nichter (daniel-nichter)]

Just one spelling suggestion, otherwise code is fine.

review: Approve

=== modified file 'bin/pt-slave-find'
--- bin/pt-slave-find	2015-01-23 10:19:56 +0000
+++ bin/pt-slave-find	2015-03-19 20:58:57 +0000
@@ -3778,6 +3778,7 @@
       node          => $root,
       print_node    => $print_node,
       MasterSlave   => $ms,
+	   resolve_address => $o->get('resolve-address'),
    );
 
    return 0;
@@ -3823,7 +3824,7 @@
 
 sub print_node_hostname {
    my ( %args ) = @_;
-   my ($ms, $node, $level) = @args{qw(MasterSlave node level)};
+   my ($ms, $node, $level, $resolve_address) = @args{qw(MasterSlave node level resolve_address)};
    die "I need a node" unless $node;
    $level ||= 0;
 
@@ -3833,15 +3834,16 @@
    my $prefix = $level ? (' ' x (($level-1)*3) . '+- ') : '';
 
    PTDEBUG && _d('level', $level, 'host', $host);
-   print "$prefix$host\n";
+  
+   print_host($prefix, $host, $resolve_address);
 
    return;
 }
 
 sub print_node_summary {
    my ( %args ) = @_;
-   my ($ms, $node, $level)
-      = @args{qw(MasterSlave node level)};
+   my ($ms, $node, $level, $resolve_address)
+      = @args{qw(MasterSlave node level resolve_address)};
    die "I need a node" unless $node;
    $level ||= 0;
 
@@ -3851,7 +3853,7 @@
 
    PTDEBUG && _d('level', $level, 'host', $host);
 
-   print "$prefix$host\n";
+   print_host($prefix, $host, $resolve_address);
 
    my $dbh = $node->{dbh};
    if ( !$dbh ) {
@@ -3923,6 +3925,28 @@
    return;
 }
 
+sub print_host {
+   my ($prefix, $host, $resolve_address) = @_;
+
+   my $hostname;
+   # resolve address to hostname if user requested it
+   if($resolve_address) {
+      use Socket;
+      my $without_port = $host;  
+      $without_port =~ s/:\d*$//;  # strip port from ip address
+      my $packed = inet_aton($without_port);
+      if ($packed) {
+	      $hostname = gethostbyaddr($packed, AF_INET);
+      }
+   }
+   if ($hostname) {
+	   print "$prefix$host ($hostname)\n";
+   } 
+   else {
+	   print "$prefix$host\n";
+   }
+}
+
 sub _d {
    my ($package, undef, $line) = caller 0;
    @_ = map { (my $temp = $_) =~ s/\n/\n# /g; $temp; }
@@ -4155,6 +4179,16 @@
 
 =back
 
+=item --resolve-address
+
+Resolve ip-address to hostname. Report will print both IP and hostname.
+
+Example:
+
+   10.10.7.14 (dbase1.sample.net)
+
+Might delay runtime a few seconds.
+
 =item --set-vars
 
 type: Array
 
=== modified file 't/pt-slave-find/pt-slave-find.t'
--- t/pt-slave-find/pt-slave-find.t	2012-08-14 23:08:06 +0000
+++ t/pt-slave-find/pt-slave-find.t	2015-03-19 20:58:57 +0000
@@ -43,7 +43,7 @@
    plan skip_all => 'Cannot connect to second sandbox slave';
 }
 else {
-   plan tests => 9;
+   plan tests => 10;
 }
 
 my @args = ('h=127.0.0.1,P=12345,u=msandbox,p=msandbox');
@@ -67,6 +67,17 @@
 EOF
 is($output, $expected, 'Master with slave and slave of slave');
 
+###############################################################################
+# Test --resolve-hostname option (we don't know the hostname of the test
+# machine so we settle for any non null string)
+###############################################################################
+$output = `$trunk/bin/pt-slave-find -h 127.0.0.1 -P 12345 -u msandbox -p msandbox --report-format hostname --resolve-address`;
+like (   
+   $output,
+   qr/127\.0\.0\.1:12345\s+\(\w+\)/s,
+   "--resolve-address option"
+) or diag($output);
+
 # #############################################################################
 # Until MasterSlave::find_slave_hosts() is improved to overcome the problems
 # with SHOW SLAVE HOSTS, this test won't work.
@@ -146,6 +157,7 @@
    "Summary report format",
 );
 
+
 # #############################################################################
 # Done.
 # #############################################################################