Code review comment for lp:~percona-toolkit-dev/percona-toolkit/pt-kill-should-print-query-fingerprint-hash-after-killing-a-query-1391240

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

This mixes terms: fingerprint is "select c from t where id=?", checksum is 0xA4F90EC8, so --fingerprint is misleading: users will expect the former. Look in pqd docs and see if we call it "query ID" or "query checksum" and then either --query-id or --query-checksum.

Also the line

   my $chksm = uc substr(md5_hex($fp), -16);

duplicates Transformers::make_checksum(). Granted it's just one line though.

review: Needs Fixing

« Back to merge proposal