Code review comment for lp:~percona-toolkit-dev/percona-toolkit/pt-fingerprint-broken-fingerprinting-of-specific-INSERT-REPLACE-queries-1289516

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

The test does not seem to address the issue originally reported:

$ pt-fingerprint --query "REPLACE INTO a VALUES('INSERT INTO foo VALUES (1),(2)')"

replace into a values('insert into foo values(?+)

That query is going to be very difficult to fingerprinted, perhaps not even possible because fingerprinting is currently heuristic, pattern-based.

« Back to merge proposal