Code review comment for lp:~percona-toolkit-dev/percona-toolkit/pt-duplicate-key-checker-skips-report-when-verbose-on-1402730

Revision history for this message
Frank Cizmich (frank-cizmich) wrote :

The "verbose" part was not visible in the context.

Old code:

            if ( $o->got('verbose') ) {
               print_all_keys($keys, $tbl, \%seen_tbl) if $keys;
               print_all_keys($fks, $tbl, \%seen_tbl) if $fks;
            }
            else {
               PTDEBUG && _d('Getting duplicate keys on',
                  $tbl->{db}, $tbl->{tbl});
                ....etc
New code:

            if ( $o->got('verbose') ) {
               print_all_keys($keys, $tbl, \%seen_tbl) if $keys;
               print_all_keys($fks, $tbl, \%seen_tbl) if $fks;
            }
            PTDEBUG && _d('Getting duplicate keys on',
               $tbl->{db}, $tbl->{tbl});
               ....etc

« Back to merge proposal