Merge lp:~percona-toolkit-dev/percona-toolkit/fixed-various-test-issues-1365085 into lp:~percona-toolkit-dev/percona-toolkit/release-2.2.11
Proposed by
Frank Cizmich
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Daniel Nichter | ||||
Approved revision: | 617 | ||||
Merged at revision: | 621 | ||||
Proposed branch: | lp:~percona-toolkit-dev/percona-toolkit/fixed-various-test-issues-1365085 | ||||
Merge into: | lp:~percona-toolkit-dev/percona-toolkit/release-2.2.11 | ||||
Diff against target: |
86 lines (+48/-1) 3 files modified
t/lib/Percona/Toolkit.t (+16/-0) t/pt-duplicate-key-checker/standard_options.t (+26/-1) t/pt-fifo-split/pt-fifo-split.t (+6/-0) |
||||
To merge this branch: | bzr merge lp:~percona-toolkit-dev/percona-toolkit/fixed-various-test-issues-1365085 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Nichter | Approve | ||
Review via email:
|
Description of the change
t/lib/Percona/
Created an aux function to correctly sort version numbers (some bzr versions do not do it).
This enables the test to correctly fetch the latest version number from the tags.
t/pt-duplicate-
Sometimes the test command hanged. Set a timeout of 5 seconds
t/pt-fifo-
Sometimes freezes on CentOS despite the coded precautions. Resorted to simply sleeping 3 seconds to avoid deadlock.
To post a comment you must log in.
I don't really understand the problems and thus fixes, but you know more about the tests than me, so if it works for you then great.