Merge lp:~percona-toolkit-dev/percona-toolkit/change-diskstats-group-by-default-fix-bug-952727 into lp:percona-toolkit/2.1

Proposed by Baron Schwartz
Status: Merged
Merged at revision: 250
Proposed branch: lp:~percona-toolkit-dev/percona-toolkit/change-diskstats-group-by-default-fix-bug-952727
Merge into: lp:percona-toolkit/2.1
Diff against target: 36 lines (+9/-5)
2 files modified
bin/pt-diskstats (+6/-5)
t/pt-query-digest/mirror.t (+3/-0)
To merge this branch: bzr merge lp:~percona-toolkit-dev/percona-toolkit/change-diskstats-group-by-default-fix-bug-952727
Reviewer Review Type Date Requested Status
Daniel Nichter Approve
Review via email: mp+100173@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Baron Schwartz (baron-xaprb) wrote :

I've run all the tests and they pass.

Revision history for this message
Daniel Nichter (daniel-nichter) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/pt-diskstats'
--- bin/pt-diskstats 2012-03-07 23:41:54 +0000
+++ bin/pt-diskstats 2012-03-30 15:32:24 +0000
@@ -3938,12 +3938,13 @@
39383938
3939=item --group-by3939=item --group-by
39403940
3941type: string; default: disk3941type: string; default: all
39423942
3943Group-by mode: disk, sample, or all. In B<disk> mode, each line of output shows3943Group-by mode: disk, sample, or all. In B<disk> mode, each line of output
3944one disk device. In B<sample> mode, each line of output shows one sample of3944shows one disk device, with the statistics computed since the tool started. In
3945statistics. In B<all> mode, each line of output shows one sample and one disk3945B<sample> mode, each line of output shows one sample of statistics, with all
3946device.3946disks averaged together. In B<all> mode, each line of output shows one sample
3947and one disk device.
39473948
3948=item --headers3949=item --headers
39493950
39503951
=== modified file 't/pt-query-digest/mirror.t'
--- t/pt-query-digest/mirror.t 2012-03-06 20:23:20 +0000
+++ t/pt-query-digest/mirror.t 2012-03-30 15:32:24 +0000
@@ -36,6 +36,9 @@
36my $pid_file = "/tmp/pt-query-digest-mirror-test.pid";36my $pid_file = "/tmp/pt-query-digest-mirror-test.pid";
37diag(`rm $pid_file 2>/dev/null`);37diag(`rm $pid_file 2>/dev/null`);
3838
39my $pid_file = '/tmp/pt-query-digest.test.pid';
40`rm -rf $pid_file >/dev/null`;
41
39# ##########################################################################42# ##########################################################################
40# Tests for swapping --processlist and --execute43# Tests for swapping --processlist and --execute
41# ##########################################################################44# ##########################################################################

Subscribers

People subscribed via source and target branches