Code review comment for lp:~percona-toolkit-dev/percona-toolkit/OptionParser-remove-optional_value

Revision history for this message
Daniel Nichter (daniel-nichter) wrote :

516for my $exec ( grep { slurp_file($_) =~ /package Pingback;/ }
 517 grep { !/~/ }
 518 glob("$trunk/bin/*")
 519 )

That's good, but let's do it a little more light-weight. Remember, our poor test boxes are already strained. Why not just:

my @vc_tools = map { /(\S+)/ } `grep --files-with-matches Pingback $trunk/bin/*`;
foreach my $tool ( @vc_tools ) {
...

In this error: "--version-check invalud value $value. Accepted values are", double space between the sentence, i.e. \s\s instead of just \s before "Accepted" (blame Baron for encouraging my grammatical zealousness).

Typo in --version-check docs: ""auto" first tries using "https", and resolts to"

review: Needs Fixing

« Back to merge proposal