Code review comment for lp:~percona-dev/percona-server/no-warnings

Revision history for this message
Yasufumi Kinoshita (yasufumi-kinoshita) wrote :

I mean it should be done by the person who know the code well.

In this case, you may break logic of the exist code.
Simple decrement of the warning without knowledge may cause broken code.

If you don't change the sign of the types, it works fine 100% as intended by me.

I always aware all workloads all over the world.
Even if it is very rare case, I should be consider.

So, the warning decrement activity should be done by the author ideally,
if you still insist it should be done.

« Back to merge proposal