Merge lp:~percona-dev/percona-server/5.1.54-final-fix-show-slave-status-nolock into lp:percona-server/release-5.1.54-12

Proposed by Oleg Tsarev
Status: Merged
Merged at revision: 189
Proposed branch: lp:~percona-dev/percona-server/5.1.54-final-fix-show-slave-status-nolock
Merge into: lp:percona-server/release-5.1.54-12
Diff against target: 101 lines (+42/-30)
2 files modified
mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.result (+9/-11)
mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.test (+33/-19)
To merge this branch: bzr merge lp:~percona-dev/percona-server/5.1.54-final-fix-show-slave-status-nolock
Reviewer Review Type Date Requested Status
Aleksandr Kuzminsky (community) Approve
Review via email: mp+45380@code.launchpad.net

This proposal supersedes a proposal from 2011-01-06.

Description of the change

final fix test for patch show_slave_status_nolock.patch. Unfortunatelly, SHOW SLAVE STATUS NOLOCK doesn't determenistic, because doesnt' lock mutex. As result we get float result of tests. Now I remove the SHOW SLAVE STATUS NOLOCK output from the test's result

To post a comment you must log in.
Revision history for this message
Aleksandr Kuzminsky (akuzminsky) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.result'
--- mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.result 2011-01-06 09:44:49 +0000
+++ mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.result 2011-01-06 14:15:09 +0000
@@ -6,18 +6,16 @@
6start slave;6start slave;
7DROP TABLE IF EXISTS t;7DROP TABLE IF EXISTS t;
8CREATE TABLE t(id INT);8CREATE TABLE t(id INT);
9INSERT INTO t SELECT SLEEP(5);9INSERT INTO t SELECT SLEEP(10);
10STOP SLAVE;10STOP SLAVE;
11select count(*) from t;11Warnings:
12count(*)12Note 1592 Statement may not be safe to log in statement format.
13013master count(*)
14master 1
15slave count(*)
16slave 0
14SHOW SLAVE STATUS NOLOCK;17SHOW SLAVE STATUS NOLOCK;
15Slave_IO_State Master_Host Master_User Master_Port Connect_Retry Master_Log_File Read_Master_Log_Pos Relay_Log_File Relay_Log_Pos Relay_Master_Log_File Slave_IO_Running Slave_SQL_Running Replicate_Do_DB Replicate_Ignore_DB Replicate_Do_Table Replicate_Ignore_Table Replicate_Wild_Do_Table Replicate_Wild_Ignore_Table Last_Errno Last_Error Skip_Counter Exec_Master_Log_Pos Relay_Log_Space Until_Condition Until_Log_File Until_Log_Pos Master_SSL_Allowed Master_SSL_CA_File Master_SSL_CA_Path Master_SSL_Cert Master_SSL_Cipher Master_SSL_Key Seconds_Behind_Master Master_SSL_Verify_Server_Cert Last_IO_Errno Last_IO_Error Last_SQL_Errno Last_SQL_Error
16<STATE> <HOST> <USER> <PORT> 1 master-bin.000001 276 slave-relay-bin.000003 422 master-bin.000001 <Slave_IO_Running> <Slave_SQL_Running> 0 0 276 577 None 0 No 0 No 0 0
17select count(*) from t;
18count(*)
190
20START SLAVE;18START SLAVE;
21Warnings:19slave count(*)
22Note 1592 Statement may not be safe to log in statement format.20slave 1
23DROP TABLE t;21DROP TABLE t;
2422
=== modified file 'mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.test'
--- mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.test 2011-01-06 09:44:49 +0000
+++ mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.test 2011-01-06 14:15:09 +0000
@@ -2,32 +2,46 @@
2--source include/have_binlog_format_statement.inc2--source include/have_binlog_format_statement.inc
33
4connection master;4connection master;
5-- disable_warnings5 --disable_warnings
6DROP TABLE IF EXISTS t;6 DROP TABLE IF EXISTS t;
7-- enable_warnings7 --enable_warnings
8CREATE TABLE t(id INT);8 CREATE TABLE t(id INT);
9sync_slave_with_master;9 sync_slave_with_master;
1010
11connection master;11connection master;
12send INSERT INTO t SELECT SLEEP(5);12 send INSERT INTO t SELECT SLEEP(10);
1313
14connection slave;14connection slave;
15sleep 2;15 sleep 15;
16send STOP SLAVE;16 send STOP SLAVE;
17sleep 2;17
18connection master;
19 reap;
20
21 --disable_query_log
22 select "master",count(*) from t;
23 --enable_query_log
1824
19connection slave1;25connection slave1;
20select count(*) from t;26 --disable_query_log
21replace_column 1 <STATE> 2 <HOST> 3 <USER> 4 <PORT> 11 <Slave_IO_Running> 12 <Slave_SQL_Running>;27 select "slave",count(*) from t;
22SHOW SLAVE STATUS NOLOCK;28 --enable_query_log
23select count(*) from t;29
30 --disable_result_log
31 SHOW SLAVE STATUS NOLOCK;
32 --enable_result_log
2433
25connection slave;34connection slave;
26reap;35 reap;
27--source include/wait_for_slave_to_stop.inc36
28START SLAVE;37 --source include/wait_for_slave_to_stop.inc
29--source include/wait_for_slave_to_start.inc38 START SLAVE;
39 --source include/wait_for_slave_to_start.inc
40
41 --disable_query_log
42 select "slave",count(*) from t;
43 --enable_query_log
44
30connection master;45connection master;
31reap;46 DROP TABLE t;
32DROP TABLE t;
33sync_slave_with_master;47sync_slave_with_master;

Subscribers

People subscribed via source and target branches

to all changes: