Merge lp:~percona-dev/percona-server/5.1.54-final-fix-show-slave-status-nolock into lp:percona-server/release-5.1.54-12

Proposed by Oleg Tsarev
Status: Merged
Merged at revision: 189
Proposed branch: lp:~percona-dev/percona-server/5.1.54-final-fix-show-slave-status-nolock
Merge into: lp:percona-server/release-5.1.54-12
Diff against target: 101 lines (+42/-30)
2 files modified
mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.result (+9/-11)
mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.test (+33/-19)
To merge this branch: bzr merge lp:~percona-dev/percona-server/5.1.54-final-fix-show-slave-status-nolock
Reviewer Review Type Date Requested Status
Aleksandr Kuzminsky (community) Approve
Review via email: mp+45380@code.launchpad.net

This proposal supersedes a proposal from 2011-01-06.

Description of the change

final fix test for patch show_slave_status_nolock.patch. Unfortunatelly, SHOW SLAVE STATUS NOLOCK doesn't determenistic, because doesnt' lock mutex. As result we get float result of tests. Now I remove the SHOW SLAVE STATUS NOLOCK output from the test's result

To post a comment you must log in.
Revision history for this message
Aleksandr Kuzminsky (akuzminsky) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.result'
2--- mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.result 2011-01-06 09:44:49 +0000
3+++ mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.result 2011-01-06 14:15:09 +0000
4@@ -6,18 +6,16 @@
5 start slave;
6 DROP TABLE IF EXISTS t;
7 CREATE TABLE t(id INT);
8-INSERT INTO t SELECT SLEEP(5);
9+INSERT INTO t SELECT SLEEP(10);
10 STOP SLAVE;
11-select count(*) from t;
12-count(*)
13-0
14+Warnings:
15+Note 1592 Statement may not be safe to log in statement format.
16+master count(*)
17+master 1
18+slave count(*)
19+slave 0
20 SHOW SLAVE STATUS NOLOCK;
21-Slave_IO_State Master_Host Master_User Master_Port Connect_Retry Master_Log_File Read_Master_Log_Pos Relay_Log_File Relay_Log_Pos Relay_Master_Log_File Slave_IO_Running Slave_SQL_Running Replicate_Do_DB Replicate_Ignore_DB Replicate_Do_Table Replicate_Ignore_Table Replicate_Wild_Do_Table Replicate_Wild_Ignore_Table Last_Errno Last_Error Skip_Counter Exec_Master_Log_Pos Relay_Log_Space Until_Condition Until_Log_File Until_Log_Pos Master_SSL_Allowed Master_SSL_CA_File Master_SSL_CA_Path Master_SSL_Cert Master_SSL_Cipher Master_SSL_Key Seconds_Behind_Master Master_SSL_Verify_Server_Cert Last_IO_Errno Last_IO_Error Last_SQL_Errno Last_SQL_Error
22-<STATE> <HOST> <USER> <PORT> 1 master-bin.000001 276 slave-relay-bin.000003 422 master-bin.000001 <Slave_IO_Running> <Slave_SQL_Running> 0 0 276 577 None 0 No 0 No 0 0
23-select count(*) from t;
24-count(*)
25-0
26 START SLAVE;
27-Warnings:
28-Note 1592 Statement may not be safe to log in statement format.
29+slave count(*)
30+slave 1
31 DROP TABLE t;
32
33=== modified file 'mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.test'
34--- mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.test 2011-01-06 09:44:49 +0000
35+++ mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.test 2011-01-06 14:15:09 +0000
36@@ -2,32 +2,46 @@
37 --source include/have_binlog_format_statement.inc
38
39 connection master;
40--- disable_warnings
41-DROP TABLE IF EXISTS t;
42--- enable_warnings
43-CREATE TABLE t(id INT);
44-sync_slave_with_master;
45+ --disable_warnings
46+ DROP TABLE IF EXISTS t;
47+ --enable_warnings
48+ CREATE TABLE t(id INT);
49+ sync_slave_with_master;
50
51 connection master;
52-send INSERT INTO t SELECT SLEEP(5);
53+ send INSERT INTO t SELECT SLEEP(10);
54
55 connection slave;
56-sleep 2;
57-send STOP SLAVE;
58-sleep 2;
59+ sleep 15;
60+ send STOP SLAVE;
61+
62+connection master;
63+ reap;
64+
65+ --disable_query_log
66+ select "master",count(*) from t;
67+ --enable_query_log
68
69 connection slave1;
70-select count(*) from t;
71-replace_column 1 <STATE> 2 <HOST> 3 <USER> 4 <PORT> 11 <Slave_IO_Running> 12 <Slave_SQL_Running>;
72-SHOW SLAVE STATUS NOLOCK;
73-select count(*) from t;
74+ --disable_query_log
75+ select "slave",count(*) from t;
76+ --enable_query_log
77+
78+ --disable_result_log
79+ SHOW SLAVE STATUS NOLOCK;
80+ --enable_result_log
81
82 connection slave;
83-reap;
84---source include/wait_for_slave_to_stop.inc
85-START SLAVE;
86---source include/wait_for_slave_to_start.inc
87+ reap;
88+
89+ --source include/wait_for_slave_to_stop.inc
90+ START SLAVE;
91+ --source include/wait_for_slave_to_start.inc
92+
93+ --disable_query_log
94+ select "slave",count(*) from t;
95+ --enable_query_log
96+
97 connection master;
98-reap;
99-DROP TABLE t;
100+ DROP TABLE t;
101 sync_slave_with_master;

Subscribers

People subscribed via source and target branches

to all changes: