Percona Server moved to https://jira.percona.com/projects/PS

Code review comment for lp:~percona-dev/percona-server/5.1-kill_idle_transaction-innodb_fake_changes

  1. 5.1-kill_idle_transaction-innodb_fake_changes
  2. Merge into 5.1
Revision history for this message
Yasufumi Kinoshita (yasufumi-kinoshita) wrote :

I don't know how to treat is correct.
It is problem about error handling intention at mysqld.
InnoDB (this patch) is just returning error at ht->commit() at ha_commit_one_phase().

At normal InnoDB, innobase_commit() always returns 0.
So mysqld might not be prepared for retuning error from ha->commit()?

It seems just to avoid the assertion that sandwitched by
"
thd->main_da.can_overwrite_status= TRUE;
...
thd->main_da.can_overwrite_status= FALSE;
"

But I don't know whether it is correct as mysqld intention.

« Back to merge proposal