Code review comment for lp:~percona-dev/percona-patches/dict-size-limit

Revision history for this message
Peter Zaitsev (pz-percona) wrote :

Yasufumi,

So with your patch Innodb dictionary can be set not to go over
table_cache in size ?

Wednesday, January 28, 2009, 5:15:55 PM, you wrote:

> Vadim,

> If a handler of certain table exists, we don't remove the dictionary entry
> even if the hendler is not used.

> So, we shouhld use "FLUSH TABLES" to close such handler

> or use "small table_cache" to close such handler automatocally.

> Vadim Tkachenko wrote:
>> Yasufumi,
>>
>>
>> So you cleaning dictionary cache only by FLUSH TABLE ?
>>
>> I think it will not work, we should make it automatically.
>>
>> FLUSH TABLE is very expensive and performance hurt command

--
Peter Zaitsev, CEO, Percona Inc.
Tel: +1 888 401 3401 ext 501 Skype: peter_zaitsev
24/7 Emergency Line +1 888 401 3401 ext 911
Our Services: http://www.percona.com/services.html
Our Blog: http://www.mysqlperformanceblog.com/

« Back to merge proposal