Code review comment for lp:~percona-core/percona-xtrabackup/release-2.0.6

It is in fact the reason for bug #1158948.

Our packaging scripts define CXX=gcc for some obscure reason. This worked for server versions < 5.6, but 5.6 doesn't build with CXX=gcc, it requires CXX=g++ (or just not overriding CXX, in which case CMake would use g++ anyway).

Now what the changes in release-2.0.6 do is that instead of changing CXX to g++ they introduce this CXX_56=g++ thing. But only in build-dpkg.sh and build-rpm.sh, not in build-binary.sh. And that's why innodb56 build fails when run from build-binary.sh. One would expect that build-binary.sh would fail in such a case. But we also have the code in build-binary.sh to suppress all build failures with the "( ... ) || false" construct. So build-binary.sh fails to build innodb56, but completes successfully.

Here's what I suggest we do:

- remove CXX_56, replace it with "CXX=g++" in all build-*.sh scripts
- remove that construct to suppress build failures