Code review comment for lp:~percona-core/percona-xtrabackup/release-2.0.6

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Hi Ignacio,

On Thu, 21 Mar 2013 21:43:20 -0000, Ignacio Nin wrote:
>> Are there any specific reasons to not just use "CXX=${CXX:-g++}" instead of
>> introducing CXX_56?
>
> PS 5.1 and 5.5 are compiled with gcc by default, so CXX gets exported to CXX=gcc by default. However, 5.6 won't build with CXX=gcc so we need to default to CXX=g++ for it. I created CXX_56 so we can specifically override CXX for 5.6 separately from 5.5 and 5.1.
>

Are you saying that PS 5.1/5.5 will *not* compile with CXX=g++? As in,
what exactly is wrong with CXX=g++? I use it locally to build XB and
don't have any issues.

« Back to merge proposal