Merge lp:~percona-core/percona-server/t12-crash-safe-slave into lp:~percona-core/percona-server/t12
Proposed by
George Ormond Lorch III
Status: | Merged |
---|---|
Merge reported by: | George Ormond Lorch III |
Merged at revision: | not available |
Proposed branch: | lp:~percona-core/percona-server/t12-crash-safe-slave |
Merge into: | lp:~percona-core/percona-server/t12 |
To merge this branch: | bzr merge lp:~percona-core/percona-server/t12-crash-safe-slave |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vlad Lesin (community) | g2 | Approve | |
Sergei Glushchenko (community) | g2 | Approve | |
Review via email: mp+191254@code.launchpad.net |
Description of the change
To post a comment you must log in.
Hi George!
I've looked at the patch and I have couple of questions.
* MYSQL_SERVER is defined because we use some MySQL headers in
ha_innodb.cc. Why do we use ifdef MYSQL_SERVER and #ifndef
MYSQL_SERVER in ha_innodb.cc? We defined it unconditionally for
this file, so ha_innodb.cc seems cannot be built MYSQL_CLIENT defined.
* line 845 of the diff seems just adds an empty line
* can you clarify what is the Crash Safe Slave feature and why it
cannot be fully replaced with our Crash Resistant Replication?
Why do we need to store additional set of log coordinates in trx
record?