Code review comment for lp:~percona-core/percona-server/t12-crash-safe-slave

Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Nice, George, sounds good for me. I haven't really had a hope that we can easily calculate one pos given the other, just wanted you to confirm. I saw you comment with two different calculations but I couldn't figure out where

rli->group_master_log_pos +
       (rli->future_event_relay_log_pos - rli->group_relay_log_pos);

points to :)

Probably this formula should be commented better in our code as well.

I am approving this MP. Well done!

review: Approve (g2)

« Back to merge proposal