Merge lp:~percona-core/percona-server/release-5.1.66-14.2 into lp:percona-server/5.1

Proposed by Stewart Smith
Status: Merged
Approved by: Stewart Smith
Approved revision: no longer in the source branch.
Merged at revision: 515
Proposed branch: lp:~percona-core/percona-server/release-5.1.66-14.2
Merge into: lp:percona-server/5.1
Diff against target: 178 lines (+74/-0) (has conflicts)
5 files modified
Makefile (+5/-0)
Percona-Server/storage/innodb_plugin/log/log0online.c (+54/-0)
build/debian/rules (+4/-0)
build/percona-server.spec (+4/-0)
doc/source/diagnostics/slow_extended.rst (+7/-0)
Text conflict in Makefile
Text conflict in Percona-Server/storage/innodb_plugin/log/log0online.c
Text conflict in build/debian/rules
Text conflict in build/percona-server.spec
Text conflict in doc/source/diagnostics/slow_extended.rst
To merge this branch: bzr merge lp:~percona-core/percona-server/release-5.1.66-14.2
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Needs Fixing
Stewart Smith (community) Approve
Review via email: mp+143817@code.launchpad.net

This proposal supersedes a proposal from 2013-01-16.

Description of the change

Changes for 5.1.66-14.2

To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote : Posted in a previous version of this proposal

This MP might be missing a prerequisite branch

review: Needs Information
Revision history for this message
Stewart Smith (stewart) wrote :

approved (this is just simple merge when merged with --weave)

review: Approve
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

But merge conflicts?

review: Needs Fixing
Revision history for this message
Stewart Smith (stewart) wrote :

Laurynas Biveinis <email address hidden> writes:
> Review: Needs Fixing
>
> But merge conflicts?

But none with --weave merge method. One of those wonderful strange things.

--
Stewart Smith

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile'
--- Makefile 2012-10-16 04:49:59 +0000
+++ Makefile 2013-01-18 03:25:31 +0000
@@ -1,5 +1,10 @@
1<<<<<<< TREE
1MYSQL_VERSION=5.1.662MYSQL_VERSION=5.1.66
2PERCONA_SERVER_VERSION=rel14.13PERCONA_SERVER_VERSION=rel14.1
4=======
5MYSQL_VERSION=5.1.66
6PERCONA_SERVER_VERSION=rel14.2
7>>>>>>> MERGE-SOURCE
3PERCONA_SERVER ?=Percona-Server-$(MYSQL_VERSION)-$(PERCONA_SERVER_VERSION)8PERCONA_SERVER ?=Percona-Server-$(MYSQL_VERSION)-$(PERCONA_SERVER_VERSION)
4PERCONA_SERVER_SHORT_1 ?=Percona-Server-$(MYSQL_VERSION)9PERCONA_SERVER_SHORT_1 ?=Percona-Server-$(MYSQL_VERSION)
5PERCONA_SERVER_SHORT_2 ?=Percona-Server10PERCONA_SERVER_SHORT_2 ?=Percona-Server
611
=== modified file 'Percona-Server/storage/innodb_plugin/handler/i_s.cc'
=== modified file 'Percona-Server/storage/innodb_plugin/log/log0online.c'
--- Percona-Server/storage/innodb_plugin/log/log0online.c 2013-01-04 07:28:01 +0000
+++ Percona-Server/storage/innodb_plugin/log/log0online.c 2013-01-18 03:25:31 +0000
@@ -385,6 +385,7 @@
385#endif385#endif
386}386}
387387
388<<<<<<< TREE
388/*********************************************************************//**389/*********************************************************************//**
389Check if missing, if any, LSN interval can be read and tracked using the390Check if missing, if any, LSN interval can be read and tracked using the
390current LSN value, the LSN value where the tracking stopped, and the log group391current LSN value, the LSN value where the tracking stopped, and the log group
@@ -416,6 +417,39 @@
416}417}
417418
418419
420=======
421/*********************************************************************//**
422Check if missing, if any, LSN interval can be read and tracked using the
423current LSN value, the LSN value where the tracking stopped, and the log group
424capacity.
425
426@return TRUE if the missing interval can be tracked or if there's no missing
427data. */
428static
429ibool
430log_online_can_track_missing(
431/*=========================*/
432 ib_uint64_t last_tracked_lsn, /*!<in: last tracked LSN */
433 ib_uint64_t tracking_start_lsn) /*!<in: current LSN */
434{
435 /* last_tracked_lsn might be < MIN_TRACKED_LSN in the case of empty
436 bitmap file, handle this too. */
437 last_tracked_lsn = ut_max(last_tracked_lsn, MIN_TRACKED_LSN);
438
439 if (last_tracked_lsn > tracking_start_lsn) {
440 fprintf(stderr,
441 "InnoDB: Error: last tracked LSN is in future. This "
442 "can be caused by mismatched bitmap files.\n");
443 exit(1);
444 }
445
446 return (last_tracked_lsn == tracking_start_lsn)
447 || (log_sys->lsn - last_tracked_lsn
448 <= log_sys->log_group_capacity);
449}
450
451
452>>>>>>> MERGE-SOURCE
419/****************************************************************//**453/****************************************************************//**
420Diagnose a gap in tracked LSN range on server startup due to crash or454Diagnose a gap in tracked LSN range on server startup due to crash or
421very fast shutdown and try to close it by tracking the data455very fast shutdown and try to close it by tracking the data
@@ -431,11 +465,19 @@
431{465{
432 ut_ad(last_tracked_lsn != tracking_start_lsn);466 ut_ad(last_tracked_lsn != tracking_start_lsn);
433467
468<<<<<<< TREE
434 fprintf(stderr, "InnoDB: last tracked LSN in \'%s\' is %llu, but the "469 fprintf(stderr, "InnoDB: last tracked LSN in \'%s\' is %llu, but the "
435 "last checkpoint LSN is %llu. This might be due to a server "470 "last checkpoint LSN is %llu. This might be due to a server "
436 "crash or a very fast shutdown. ", log_bmp_sys->out.name,471 "crash or a very fast shutdown. ", log_bmp_sys->out.name,
437 last_tracked_lsn, tracking_start_lsn);472 last_tracked_lsn, tracking_start_lsn);
438473
474=======
475 fprintf(stderr, "InnoDB: last tracked LSN is %llu, but the last "
476 "checkpoint LSN is %llu. This might be due to a server "
477 "crash or a very fast shutdown. ", last_tracked_lsn,
478 tracking_start_lsn);
479
480>>>>>>> MERGE-SOURCE
439 /* See if we can fully recover the missing interval */481 /* See if we can fully recover the missing interval */
440 if (log_online_can_track_missing(last_tracked_lsn,482 if (log_online_can_track_missing(last_tracked_lsn,
441 tracking_start_lsn)) {483 tracking_start_lsn)) {
@@ -443,8 +485,13 @@
443 fprintf(stderr,485 fprintf(stderr,
444 "Reading the log to advance the last tracked LSN.\n");486 "Reading the log to advance the last tracked LSN.\n");
445487
488<<<<<<< TREE
446 log_bmp_sys->start_lsn = ut_max_uint64(last_tracked_lsn,489 log_bmp_sys->start_lsn = ut_max_uint64(last_tracked_lsn,
447 MIN_TRACKED_LSN);490 MIN_TRACKED_LSN);
491=======
492 log_bmp_sys->start_lsn = ut_max(last_tracked_lsn,
493 MIN_TRACKED_LSN);
494>>>>>>> MERGE-SOURCE
448 log_set_tracked_lsn(log_bmp_sys->start_lsn);495 log_set_tracked_lsn(log_bmp_sys->start_lsn);
449 log_online_follow_redo_log();496 log_online_follow_redo_log();
450 ut_ad(log_bmp_sys->end_lsn >= tracking_start_lsn);497 ut_ad(log_bmp_sys->end_lsn >= tracking_start_lsn);
@@ -560,10 +607,17 @@
560{607{
561 ibool success;608 ibool success;
562 ib_uint64_t tracking_start_lsn609 ib_uint64_t tracking_start_lsn
610<<<<<<< TREE
563 = ut_max_uint64(log_sys->last_checkpoint_lsn, MIN_TRACKED_LSN);611 = ut_max_uint64(log_sys->last_checkpoint_lsn, MIN_TRACKED_LSN);
564 os_file_dir_t bitmap_dir;612 os_file_dir_t bitmap_dir;
565 os_file_stat_t bitmap_dir_file_info;613 os_file_stat_t bitmap_dir_file_info;
566 ib_uint64_t last_file_start_lsn = MIN_TRACKED_LSN;614 ib_uint64_t last_file_start_lsn = MIN_TRACKED_LSN;
615=======
616 = ut_max(log_sys->last_checkpoint_lsn, MIN_TRACKED_LSN);
617 os_file_dir_t bitmap_dir;
618 os_file_stat_t bitmap_dir_file_info;
619 ib_uint64_t last_file_start_lsn = MIN_TRACKED_LSN;
620>>>>>>> MERGE-SOURCE
567621
568 /* Assert (could be compile-time assert) that bitmap data start and end622 /* Assert (could be compile-time assert) that bitmap data start and end
569 in a bitmap block is 8-byte aligned */623 in a bitmap block is 8-byte aligned */
570624
=== modified file 'build/debian/rules'
--- build/debian/rules 2013-01-17 23:03:41 +0000
+++ build/debian/rules 2013-01-18 03:25:31 +0000
@@ -9,7 +9,11 @@
9TMP=$(CURDIR)/debian/tmp/9TMP=$(CURDIR)/debian/tmp/
1010
11major_version_default=1411major_version_default=14
12<<<<<<< TREE
12minor_version_default=113minor_version_default=1
14=======
15minor_version_default=2
16>>>>>>> MERGE-SOURCE
1317
14ARCH = $(shell dpkg-architecture -qDEB_BUILD_ARCH)18ARCH = $(shell dpkg-architecture -qDEB_BUILD_ARCH)
15ARCH_OS = $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS)19ARCH_OS = $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS)
1620
=== modified file 'build/percona-server.spec'
--- build/percona-server.spec 2013-01-17 23:03:41 +0000
+++ build/percona-server.spec 2013-01-18 03:25:31 +0000
@@ -16,7 +16,11 @@
16%define community 116%define community 1
17%define mysqlversion 5.1.6617%define mysqlversion 5.1.66
18%define majorversion 1418%define majorversion 14
19<<<<<<< TREE
19%define minorversion 120%define minorversion 1
21=======
22%define minorversion 2
23>>>>>>> MERGE-SOURCE
20%define distribution rhel%{redhatversion}24%define distribution rhel%{redhatversion}
21%define release rel%{majorversion}.%{minorversion}.%{gotrevision}.%{distribution}25%define release rel%{majorversion}.%{minorversion}.%{gotrevision}.%{distribution}
2226
2327
=== modified file 'doc/source/conf.py'
=== modified file 'doc/source/diagnostics/slow_extended.rst'
--- doc/source/diagnostics/slow_extended.rst 2013-01-15 08:26:36 +0000
+++ doc/source/diagnostics/slow_extended.rst 2013-01-18 03:25:31 +0000
@@ -8,7 +8,11 @@
88
9The ability to log queries with microsecond precision is essential for measuring the work the |MySQL| server performs. The standard slow query log in |MySQL| 5.0 has only 1-second granularity, which is too coarse for all but the slowest queries. |MySQL| 5.1 has microsecond resolution, but does not have the extra information about query execution that is included in the |Percona Server|.9The ability to log queries with microsecond precision is essential for measuring the work the |MySQL| server performs. The standard slow query log in |MySQL| 5.0 has only 1-second granularity, which is too coarse for all but the slowest queries. |MySQL| 5.1 has microsecond resolution, but does not have the extra information about query execution that is included in the |Percona Server|.
1010
11<<<<<<< TREE
11You can use *Percona Toolkit*'s `pt-query-digest <http://www.percona.com/doc/percona-toolkit/2.1/pt-query-digest.html>`_ tool to aggregate similar queries together and report on those that consume the most execution time.12You can use *Percona Toolkit*'s `pt-query-digest <http://www.percona.com/doc/percona-toolkit/2.1/pt-query-digest.html>`_ tool to aggregate similar queries together and report on those that consume the most execution time.
13=======
14You can use *Percona Toolkit*'s ''pt-query-digest'' tool to aggregate similar queries together and report on those that consume the most execution time.
15>>>>>>> MERGE-SOURCE
1216
1317
14Version Specific Information18Version Specific Information
@@ -145,7 +149,10 @@
145 :conf: Yes149 :conf: Yes
146 :scope: Global, session150 :scope: Global, session
147 :dyn: Yes151 :dyn: Yes
152<<<<<<< TREE
148 :default: microtime153 :default: microtime
154=======
155>>>>>>> MERGE-SOURCE
149156
150Specifies how much information to include in your slow log. The value is a comma-delimited string, and can contain any combination of the following values:157Specifies how much information to include in your slow log. The value is a comma-delimited string, and can contain any combination of the following values:
151158

Subscribers

People subscribed via source and target branches