Merge lp:~percona-core/percona-server/release-5.1.66-14.2 into lp:percona-server/5.1

Proposed by Stewart Smith
Status: Merged
Approved by: Stewart Smith
Approved revision: no longer in the source branch.
Merged at revision: 515
Proposed branch: lp:~percona-core/percona-server/release-5.1.66-14.2
Merge into: lp:percona-server/5.1
Diff against target: 178 lines (+74/-0) (has conflicts)
5 files modified
Makefile (+5/-0)
Percona-Server/storage/innodb_plugin/log/log0online.c (+54/-0)
build/debian/rules (+4/-0)
build/percona-server.spec (+4/-0)
doc/source/diagnostics/slow_extended.rst (+7/-0)
Text conflict in Makefile
Text conflict in Percona-Server/storage/innodb_plugin/log/log0online.c
Text conflict in build/debian/rules
Text conflict in build/percona-server.spec
Text conflict in doc/source/diagnostics/slow_extended.rst
To merge this branch: bzr merge lp:~percona-core/percona-server/release-5.1.66-14.2
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Needs Fixing
Stewart Smith (community) Approve
Review via email: mp+143817@code.launchpad.net

This proposal supersedes a proposal from 2013-01-16.

Description of the change

Changes for 5.1.66-14.2

To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote : Posted in a previous version of this proposal

This MP might be missing a prerequisite branch

review: Needs Information
Revision history for this message
Stewart Smith (stewart) wrote :

approved (this is just simple merge when merged with --weave)

review: Approve
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

But merge conflicts?

review: Needs Fixing
Revision history for this message
Stewart Smith (stewart) wrote :

Laurynas Biveinis <email address hidden> writes:
> Review: Needs Fixing
>
> But merge conflicts?

But none with --weave merge method. One of those wonderful strange things.

--
Stewart Smith

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2012-10-16 04:49:59 +0000
3+++ Makefile 2013-01-18 03:25:31 +0000
4@@ -1,5 +1,10 @@
5+<<<<<<< TREE
6 MYSQL_VERSION=5.1.66
7 PERCONA_SERVER_VERSION=rel14.1
8+=======
9+MYSQL_VERSION=5.1.66
10+PERCONA_SERVER_VERSION=rel14.2
11+>>>>>>> MERGE-SOURCE
12 PERCONA_SERVER ?=Percona-Server-$(MYSQL_VERSION)-$(PERCONA_SERVER_VERSION)
13 PERCONA_SERVER_SHORT_1 ?=Percona-Server-$(MYSQL_VERSION)
14 PERCONA_SERVER_SHORT_2 ?=Percona-Server
15
16=== modified file 'Percona-Server/storage/innodb_plugin/handler/i_s.cc'
17=== modified file 'Percona-Server/storage/innodb_plugin/log/log0online.c'
18--- Percona-Server/storage/innodb_plugin/log/log0online.c 2013-01-04 07:28:01 +0000
19+++ Percona-Server/storage/innodb_plugin/log/log0online.c 2013-01-18 03:25:31 +0000
20@@ -385,6 +385,7 @@
21 #endif
22 }
23
24+<<<<<<< TREE
25 /*********************************************************************//**
26 Check if missing, if any, LSN interval can be read and tracked using the
27 current LSN value, the LSN value where the tracking stopped, and the log group
28@@ -416,6 +417,39 @@
29 }
30
31
32+=======
33+/*********************************************************************//**
34+Check if missing, if any, LSN interval can be read and tracked using the
35+current LSN value, the LSN value where the tracking stopped, and the log group
36+capacity.
37+
38+@return TRUE if the missing interval can be tracked or if there's no missing
39+data. */
40+static
41+ibool
42+log_online_can_track_missing(
43+/*=========================*/
44+ ib_uint64_t last_tracked_lsn, /*!<in: last tracked LSN */
45+ ib_uint64_t tracking_start_lsn) /*!<in: current LSN */
46+{
47+ /* last_tracked_lsn might be < MIN_TRACKED_LSN in the case of empty
48+ bitmap file, handle this too. */
49+ last_tracked_lsn = ut_max(last_tracked_lsn, MIN_TRACKED_LSN);
50+
51+ if (last_tracked_lsn > tracking_start_lsn) {
52+ fprintf(stderr,
53+ "InnoDB: Error: last tracked LSN is in future. This "
54+ "can be caused by mismatched bitmap files.\n");
55+ exit(1);
56+ }
57+
58+ return (last_tracked_lsn == tracking_start_lsn)
59+ || (log_sys->lsn - last_tracked_lsn
60+ <= log_sys->log_group_capacity);
61+}
62+
63+
64+>>>>>>> MERGE-SOURCE
65 /****************************************************************//**
66 Diagnose a gap in tracked LSN range on server startup due to crash or
67 very fast shutdown and try to close it by tracking the data
68@@ -431,11 +465,19 @@
69 {
70 ut_ad(last_tracked_lsn != tracking_start_lsn);
71
72+<<<<<<< TREE
73 fprintf(stderr, "InnoDB: last tracked LSN in \'%s\' is %llu, but the "
74 "last checkpoint LSN is %llu. This might be due to a server "
75 "crash or a very fast shutdown. ", log_bmp_sys->out.name,
76 last_tracked_lsn, tracking_start_lsn);
77
78+=======
79+ fprintf(stderr, "InnoDB: last tracked LSN is %llu, but the last "
80+ "checkpoint LSN is %llu. This might be due to a server "
81+ "crash or a very fast shutdown. ", last_tracked_lsn,
82+ tracking_start_lsn);
83+
84+>>>>>>> MERGE-SOURCE
85 /* See if we can fully recover the missing interval */
86 if (log_online_can_track_missing(last_tracked_lsn,
87 tracking_start_lsn)) {
88@@ -443,8 +485,13 @@
89 fprintf(stderr,
90 "Reading the log to advance the last tracked LSN.\n");
91
92+<<<<<<< TREE
93 log_bmp_sys->start_lsn = ut_max_uint64(last_tracked_lsn,
94 MIN_TRACKED_LSN);
95+=======
96+ log_bmp_sys->start_lsn = ut_max(last_tracked_lsn,
97+ MIN_TRACKED_LSN);
98+>>>>>>> MERGE-SOURCE
99 log_set_tracked_lsn(log_bmp_sys->start_lsn);
100 log_online_follow_redo_log();
101 ut_ad(log_bmp_sys->end_lsn >= tracking_start_lsn);
102@@ -560,10 +607,17 @@
103 {
104 ibool success;
105 ib_uint64_t tracking_start_lsn
106+<<<<<<< TREE
107 = ut_max_uint64(log_sys->last_checkpoint_lsn, MIN_TRACKED_LSN);
108 os_file_dir_t bitmap_dir;
109 os_file_stat_t bitmap_dir_file_info;
110 ib_uint64_t last_file_start_lsn = MIN_TRACKED_LSN;
111+=======
112+ = ut_max(log_sys->last_checkpoint_lsn, MIN_TRACKED_LSN);
113+ os_file_dir_t bitmap_dir;
114+ os_file_stat_t bitmap_dir_file_info;
115+ ib_uint64_t last_file_start_lsn = MIN_TRACKED_LSN;
116+>>>>>>> MERGE-SOURCE
117
118 /* Assert (could be compile-time assert) that bitmap data start and end
119 in a bitmap block is 8-byte aligned */
120
121=== modified file 'build/debian/rules'
122--- build/debian/rules 2013-01-17 23:03:41 +0000
123+++ build/debian/rules 2013-01-18 03:25:31 +0000
124@@ -9,7 +9,11 @@
125 TMP=$(CURDIR)/debian/tmp/
126
127 major_version_default=14
128+<<<<<<< TREE
129 minor_version_default=1
130+=======
131+minor_version_default=2
132+>>>>>>> MERGE-SOURCE
133
134 ARCH = $(shell dpkg-architecture -qDEB_BUILD_ARCH)
135 ARCH_OS = $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS)
136
137=== modified file 'build/percona-server.spec'
138--- build/percona-server.spec 2013-01-17 23:03:41 +0000
139+++ build/percona-server.spec 2013-01-18 03:25:31 +0000
140@@ -16,7 +16,11 @@
141 %define community 1
142 %define mysqlversion 5.1.66
143 %define majorversion 14
144+<<<<<<< TREE
145 %define minorversion 1
146+=======
147+%define minorversion 2
148+>>>>>>> MERGE-SOURCE
149 %define distribution rhel%{redhatversion}
150 %define release rel%{majorversion}.%{minorversion}.%{gotrevision}.%{distribution}
151
152
153=== modified file 'doc/source/conf.py'
154=== modified file 'doc/source/diagnostics/slow_extended.rst'
155--- doc/source/diagnostics/slow_extended.rst 2013-01-15 08:26:36 +0000
156+++ doc/source/diagnostics/slow_extended.rst 2013-01-18 03:25:31 +0000
157@@ -8,7 +8,11 @@
158
159 The ability to log queries with microsecond precision is essential for measuring the work the |MySQL| server performs. The standard slow query log in |MySQL| 5.0 has only 1-second granularity, which is too coarse for all but the slowest queries. |MySQL| 5.1 has microsecond resolution, but does not have the extra information about query execution that is included in the |Percona Server|.
160
161+<<<<<<< TREE
162 You can use *Percona Toolkit*'s `pt-query-digest <http://www.percona.com/doc/percona-toolkit/2.1/pt-query-digest.html>`_ tool to aggregate similar queries together and report on those that consume the most execution time.
163+=======
164+You can use *Percona Toolkit*'s ''pt-query-digest'' tool to aggregate similar queries together and report on those that consume the most execution time.
165+>>>>>>> MERGE-SOURCE
166
167
168 Version Specific Information
169@@ -145,7 +149,10 @@
170 :conf: Yes
171 :scope: Global, session
172 :dyn: Yes
173+<<<<<<< TREE
174 :default: microtime
175+=======
176+>>>>>>> MERGE-SOURCE
177
178 Specifies how much information to include in your slow log. The value is a comma-delimited string, and can contain any combination of the following values:
179

Subscribers

People subscribed via source and target branches