Code review comment for lp:~peppujols/stellarium/printsky

Revision history for this message
Bogdan Marinov (daggerstab) wrote :

I'll pass this time. There are several issues with the code, some caused by the fact that it has been merged from Timothy Reaves' private branch (for example, the package name, etc.). I can fix them when merging it in the trunk.

What I really want to know is what Fabien thinks about the changes in the core code (in StarMgr) - whether this is the right way to extract such data and if there is a way to make it less intrusive.

review: Abstain

« Back to merge proposal