Merge ~peppepetra/charm-prometheus-blackbox-exporter:skip_targets into charm-prometheus-blackbox-exporter:master

Proposed by Giuseppe Petralia
Status: Merged
Approved by: Alvaro Uria
Approved revision: d0df3f5e8c39c09b65830b3f40bee507084b0485
Merged at revision: d0df3f5e8c39c09b65830b3f40bee507084b0485
Proposed branch: ~peppepetra/charm-prometheus-blackbox-exporter:skip_targets
Merge into: charm-prometheus-blackbox-exporter:master
Diff against target: 32 lines (+6/-6)
1 file modified
Makefile (+6/-6)
Reviewer Review Type Date Requested Status
Alvaro Uria (community) Approve
Review via email: mp+389070@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alvaro Uria (aluria) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/Makefile b/Makefile
index 647cacd..214579c 100644
--- a/Makefile
+++ b/Makefile
@@ -37,12 +37,12 @@ clean:
37 @rm -rf ${CHARM_BUILD_DIR}/${CHARM_NAME}37 @rm -rf ${CHARM_BUILD_DIR}/${CHARM_NAME}
3838
39submodules:39submodules:
40 @echo "Cloning submodules"40 # @git submodule update --init --recursive
41 @git submodule update --init --recursive41 @echo "No submodules. Skipping."
4242
43submodules-update:43submodules-update:
44 @echo "Pulling latest updates for submodules"44 # @git submodule update --init --recursive --remote --merge
45 @git submodule update --init --recursive --remote --merge45 @echo "No submodules. Skipping."
4646
47build:47build:
48 @echo "Building charm to directory ${CHARM_BUILD_DIR}/${CHARM_NAME}"48 @echo "Building charm to directory ${CHARM_BUILD_DIR}/${CHARM_NAME}"
@@ -66,8 +66,8 @@ proof:
66 @charm proof src66 @charm proof src
6767
68unittests:68unittests:
69 @echo "Running unit tests"69 # @cd src && tox -e unit
70 @cd src && tox -e unit70 @echo "No unit tests. Skipping."
7171
72functional: build72functional: build
73 @echo "Executing functional tests in ${CHARM_BUILD_DIR}"73 @echo "Executing functional tests in ${CHARM_BUILD_DIR}"

Subscribers

People subscribed via source and target branches

to all changes: