Prometheus Blackbox Exporter Charm

Merge ~peppepetra/charm-prometheus-blackbox-exporter:skip_targets into charm-prometheus-blackbox-exporter:master

  1. Git
  2. lp:~peppepetra/charm-prometheus-blackbox-exporter
  3. skip_targets
  4. Merge into master
Proposed by Giuseppe Petralia
Status: Merged
Approved by: Alvaro Uria
Approved revision: d0df3f5e8c39c09b65830b3f40bee507084b0485
Merged at revision: d0df3f5e8c39c09b65830b3f40bee507084b0485
Proposed branch: ~peppepetra/charm-prometheus-blackbox-exporter:skip_targets
Merge into: charm-prometheus-blackbox-exporter:master
Diff against target: 32 lines (+6/-6)
1 file modified
Makefile (+6/-6)
Reviewer Review Type Date Requested Status
Alvaro Uria (community) Approve
Review via email: mp+389070@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alvaro Uria (aluria) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Makefile b/Makefile
2index 647cacd..214579c 100644
3--- a/Makefile
4+++ b/Makefile
5@@ -37,12 +37,12 @@ clean:
6 @rm -rf ${CHARM_BUILD_DIR}/${CHARM_NAME}
7
8 submodules:
9- @echo "Cloning submodules"
10- @git submodule update --init --recursive
11+ # @git submodule update --init --recursive
12+ @echo "No submodules. Skipping."
13
14 submodules-update:
15- @echo "Pulling latest updates for submodules"
16- @git submodule update --init --recursive --remote --merge
17+ # @git submodule update --init --recursive --remote --merge
18+ @echo "No submodules. Skipping."
19
20 build:
21 @echo "Building charm to directory ${CHARM_BUILD_DIR}/${CHARM_NAME}"
22@@ -66,8 +66,8 @@ proof:
23 @charm proof src
24
25 unittests:
26- @echo "Running unit tests"
27- @cd src && tox -e unit
28+ # @cd src && tox -e unit
29+ @echo "No unit tests. Skipping."
30
31 functional: build
32 @echo "Executing functional tests in ${CHARM_BUILD_DIR}"

Subscribers

People subscribed via source and target branches

to all changes: