Code review comment for ~peppepetra/charm-graylog:lp-1954764

Revision history for this message
Drew Freiberger (afreiberger) wrote :

+1 on this approach

There's a bug with the new 3.x version that the conf file now matches the regex twice, which needs to be bypassed.

I would suggest adding in a forced writing of the new_conf file if it doesn't exist, rather than checking against the settings of the SHIPPED_SNAP_DEFAULT_CONF_FILE contents before deciding to write a conf file.

review: Needs Fixing

« Back to merge proposal