Merge ~pelpsi/launchpad:ftpmaster-publisher-403-error into launchpad:master

Proposed by Simone Pelosi
Status: Merged
Approved by: Simone Pelosi
Approved revision: 5429dee347193ac3c21eea8abdb24b993e522b38
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~pelpsi/launchpad:ftpmaster-publisher-403-error
Merge into: launchpad:master
Diff against target: 20 lines (+2/-2)
1 file modified
charm/launchpad-ftpmaster-publisher/templates/vhost.conf.j2 (+2/-2)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+453808@code.launchpad.net

Commit message

Fixed wrong archive dir

Apache error AH01630 caused by wrong archive dir:
the right folder is `/srv/launchpad/archive/ubuntu-archive/`
instead of `/srv/launchpad/archive`.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Could you make the commit message slightly more informative, please?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/charm/launchpad-ftpmaster-publisher/templates/vhost.conf.j2 b/charm/launchpad-ftpmaster-publisher/templates/vhost.conf.j2
index 5206c4a..169ff83 100644
--- a/charm/launchpad-ftpmaster-publisher/templates/vhost.conf.j2
+++ b/charm/launchpad-ftpmaster-publisher/templates/vhost.conf.j2
@@ -1,13 +1,13 @@
1<VirtualHost *:80>1<VirtualHost *:80>
2 ServerName {{ domain_ftpmaster }}2 ServerName {{ domain_ftpmaster }}
33
4 DocumentRoot {{ archives_dir }}/4 DocumentRoot {{ archives_dir }}/ubuntu-archive/
55
6 CustomLog /var/log/apache2/{{ domain_ftpmaster }}-access.log combined6 CustomLog /var/log/apache2/{{ domain_ftpmaster }}-access.log combined
7 ErrorLog /var/log/apache2/{{ domain_ftpmaster }}-error.log7 ErrorLog /var/log/apache2/{{ domain_ftpmaster }}-error.log
88
9{% for distribution in ("ubuntu", "ubuntu-partner") %}9{% for distribution in ("ubuntu", "ubuntu-partner") %}
10 <Directory "{{ archives_dir }}/{{ distribution }}/">10 <Directory "{{ archives_dir }}/ubuntu-archive/{{ distribution }}/">
11 IndexOptions NameWidth=* +SuppressDescription11 IndexOptions NameWidth=* +SuppressDescription
12 Options +Indexes +FollowSymLinks12 Options +Indexes +FollowSymLinks
13 IndexIgnore favicon.ico13 IndexIgnore favicon.ico

Subscribers

People subscribed via source and target branches

to status/vote changes: