Code review comment for lp:~pefarrell/dolfin/periodic-malloc

Revision history for this message
Garth Wells (garth-wells) wrote :

On Thu, Nov 1, 2012 at 5:52 PM, Anders Logg <email address hidden> wrote:
> On Thu, Nov 01, 2012 at 03:39:22PM -0000, Garth Wells wrote:
>> Looks like this breaks with the Epetra backed again. It should be fixed properly.
>
> How will this patch affect the Epetra backend? The patch only
> introduces a fix that makes PeriodicBC run again with PETSc.
>

That's not the case. The added test in this change in

   test/unit/fem/python/PeriodicBC.py

does not work with Epetra for the same reason the code did not work
with PETSc, and which is why a proper fix is needed.

Garth

> --
> Anders
>
> --
> https://code.launchpad.net/~pefarrell/dolfin/periodic-malloc/+merge/132257
> Your team DOLFIN Core Team is subscribed to branch lp:dolfin.

« Back to merge proposal