Merge lp:~pedronis/charms/trusty/tanuki-spec-manager/ctl-gunicorn-num-workers into lp:~tanuki/charms/trusty/tanuki-spec-manager/trunk

Proposed by Samuele Pedroni
Status: Merged
Approved by: Samuele Pedroni
Approved revision: 23
Merged at revision: 23
Proposed branch: lp:~pedronis/charms/trusty/tanuki-spec-manager/ctl-gunicorn-num-workers
Merge into: lp:~tanuki/charms/trusty/tanuki-spec-manager/trunk
Diff against target: 27 lines (+6/-0)
2 files modified
config.yaml (+5/-0)
templates/upstart.conf (+1/-0)
To merge this branch: bzr merge lp:~pedronis/charms/trusty/tanuki-spec-manager/ctl-gunicorn-num-workers
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Guillermo Gonzalez Approve
Review via email: mp+270161@code.launchpad.net

Commit message

control number of gunicorn workers

Description of the change

control number of gunicorn workers

To post a comment you must log in.
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

LGTM

review: Approve
Revision history for this message
Celso Providelo (cprov) wrote :

Samuele,

Looks very good, but to avoid hitting the missing DB perms in staging, it can only land after that is fixed (facu is working on it).

Pre-approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2015-08-13 14:17:12 +0000
+++ config.yaml 2015-09-04 11:39:32 +0000
@@ -4,6 +4,11 @@
4 default: "devel"4 default: "devel"
5 description: |5 description: |
6 Environment (devel, staging, production, etc.) that we're running.6 Environment (devel, staging, production, etc.) that we're running.
7 gunicorn_num_workers:
8 type: int
9 default: 3
10 description: |
11 The number of gunicorn worker processes for handling requests.
7 config-file:12 config-file:
8 type: string13 type: string
9 description: |14 description: |
1015
=== modified file 'templates/upstart.conf'
--- templates/upstart.conf 2015-08-25 10:20:45 +0000
+++ templates/upstart.conf 2015-09-04 11:39:32 +0000
@@ -25,6 +25,7 @@
25 exec ./env/bin/gunicorn \25 exec ./env/bin/gunicorn \
26 --name=spec-manager \26 --name=spec-manager \
27 --bind=0.0.0.0 \27 --bind=0.0.0.0 \
28 --workers={{ gunicorn_num_workers }} \
28 --log-file=${LOG_DIR}/gunicorn.log \29 --log-file=${LOG_DIR}/gunicorn.log \
29 --log-level=INFO \30 --log-level=INFO \
30 --access-logfile=${LOG_DIR}/access.log \31 --access-logfile=${LOG_DIR}/access.log \

Subscribers

People subscribed via source and target branches

to all changes: