Code review comment for lp:~pedronis/charms/trusty/apache2/nagios_extra_check_https

Revision history for this message
Celso Providelo (cprov) wrote :

Samuele,

Thanks for the changes, as discussed on IRC, test failure were there pre-fork (FAILED (errors=4, failures=2)), so don't worry (much).

I think we will probably need to pass a proper "description" for each extra check (as part of our guided-alerts story), but let's do it when we need.

review: Approve

« Back to merge proposal