Code review comment for lp:~pedro.baeza/purchase-wkfl/7.0-purchase_discount

Revision history for this message
Lorenzo Battistini (elbati) wrote :

Thanks Pedro,

line 349: I think discount should not be < -100 too
line 399: amount_untaxed and following fields are present 2 times

some PEP8:

purchase_discount/__openerp__.py:21:1: O603 Manifest "license" key is missing
purchase_discount/__openerp__.py:29:5: O600 Warning unknown Manifest key ('contributors')
purchase_discount/__openerp__.py:43:5: O600 Warning unknown Manifest key ('active')
purchase_discount/purchase_discount.py:21:1: O603 Manifest "license" key is missing
purchase_discount/purchase_discount.py:24:1: E302 expected 2 blank lines, found 1
purchase_discount/purchase_discount.py:29:5: O600 Warning unknown Manifest key ('contributors')
purchase_discount/purchase_discount.py:35:75: W291 trailing whitespace
purchase_discount/purchase_discount.py:43:5: O600 Warning unknown Manifest key ('active')
purchase_discount/purchase_discount.py:43:75: W291 trailing whitespace
purchase_discount/purchase_discount.py:44:33: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:52:56: W291 trailing whitespace
purchase_discount/purchase_discount.py:86:29: E127 continuation line over-indented for visual indent
purchase_discount/purchase_discount.py:103:13: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:104:13: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:105:13: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:109:13: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:110:13: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:114:17: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:115:13: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:118:55: W291 trailing whitespace
purchase_discount/purchase_discount.py:119:13: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:119:28: E251 unexpected spaces around keyword / parameter equals
purchase_discount/purchase_discount.py:119:57: W291 trailing whitespace
purchase_discount/purchase_discount.py:120:13: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:121:13: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:123:60: W291 trailing whitespace
purchase_discount/purchase_discount.py:125:51: W291 trailing whitespace
purchase_discount/purchase_discount.py:126:13: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:126:28: E251 unexpected spaces around keyword / parameter equals
purchase_discount/purchase_discount.py:127:13: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:130:53: W291 trailing whitespace
purchase_discount/purchase_discount.py:131:13: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:131:28: E251 unexpected spaces around keyword / parameter equals
purchase_discount/purchase_discount.py:132:13: E128 continuation line under-indented for visual indent
purchase_discount/purchase_discount.py:134:28: E231 missing whitespace after ','

review: Needs Fixing

« Back to merge proposal