Merge lp:~pedro.baeza/openupgrade-addons/7.0-hr_holidays into lp:openupgrade-addons

[Pedro Manuel Baeza]

[ADD] hr_holidays: Partial migration script

[Stefan Rijnhart (Opener) (stefan-opener)]

Hi Pedro, can you please indicate in the code what is left to do?

review: Needs Information

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Stefan, it's indicated in openupgrade_analysis_work.txt. It's a minor issue, because a security group has been remove. Possible migration step can be to assign users belonging to that group to another of the remaining groups (or the new one created). It's not critical and with multiple possibilities. How do you think it's must be done?

Regards.

[Stefan Rijnhart (Opener) (stefan-opener)]

You mean the change in ir.rule? This change only reflects that in OpenERP 7.0, the manager group inherits from the user group so that the rule applies to the manager automatically. Apart from that, this particular rule only adds groups instead of overwriting them, so effectively the manager group will remain linked to the rule which is harmless. So you can remove this TODO.

I was thinking more of converting crm.case.categ to crm.meeting.type in hr.holidays.status' categ_id field but I see that the crm.case.categ model remains in OpenERP 7.0, just not in this module. So there is no logical migration path for this setting. The impact however, is very small.

It would be nice if you could note this in a file called user_notes.txt though, saying that the optional meeting types that can be configured on leave types are reset during the upgrade and may need to be reconfigured.

review: Needs Fixing

[Holger Brunn (Therp) (hbrunn)]

Agreed with Stefan

[Pedro Manuel Baeza (pedro.baeza)]

Thanks for the comments.

I have added user_notes.txt to explain categ_id change, and remove TODO.

Regards.

[Holger Brunn (Therp) (hbrunn)]

review: Approve (code review)

=== added file 'hr_holidays/migrations/7.0.1.5/openupgrade_analysis_work.txt'
--- hr_holidays/migrations/7.0.1.5/openupgrade_analysis_work.txt	1970-01-01 00:00:00 +0000
+++ hr_holidays/migrations/7.0.1.5/openupgrade_analysis_work.txt	2014-03-27 18:51:21 +0000
@@ -0,0 +1,60 @@
+---Fields in module 'hr_holidays'---
+hr_holidays  / hr.employee              / last_login (datetime)         : module is now 'hr' ('hr_holidays')
+### -> hr is a dependency, so this is not a problem
+
+hr_holidays  / hr.holidays              / case_id (many2one)            : DEL relation: crm.meeting
+hr_holidays  / hr.holidays              / meeting_id (many2one)         : NEW relation: crm.meeting
+### -> just renamed
+
+hr_holidays  / hr.holidays              / message_ids (one2many)        : NEW relation: mail.message
+### -> new functionality of mail module: nothing to do.
+
+hr_holidays  / hr.holidays.status       / categ_id (many2one)           : relation is now 'crm.meeting.type' ('crm.case.categ')
+### -> TODO: No easy migration path. Put a note in users_notes.txt
+
+---XML records in module 'hr_holidays'---
+NEW ir.actions.act_window: hr_holidays.act_hr_leave_request_to_meeting
+NEW ir.actions.act_window: hr_holidays.request_approve_allocation
+DEL ir.actions.act_window: hr_holidays.action_view_holiday_status_manager_board
+NEW ir.actions.act_window.view: hr_holidays.action_request_approve_allocation_form
+NEW ir.actions.act_window.view: hr_holidays.action_request_approve_allocation_tree
+### -> New act_window: Nothing to do
+
+NEW ir.actions.todo: base.open_menu
+DEL ir.actions.todo: hr_holidays.hr_holidays_leaves_assign_form_view_todo
+### -> New configuration wizards: Nothing to do
+
+NEW ir.model.access: hr_holidays.access_crm_meeting_type_manager
+NEW ir.model.access: hr_holidays.access_resource_calendar_leaves_user
+DEL ir.model.access: hr_holidays.access_resource_calendar_leaves_manager
+NEW ir.rule: hr_holidays.property_rule_holidays_officer
+DEL ir.rule: hr_holidays.property_rule_holidays_manager
+### -> Change of rules and access. Nothing to do
+
+NEW ir.ui.menu: hr_holidays.menu_request_approve_allocation
+DEL ir.ui.menu: hr_holidays.menu_hr_reporting_holidays
+### -> New menus: Nothing to do
+
+DEL ir.ui.view: hr_holidays.board_hr_holidays_manager_form
+### -> New view: Nothing to do
+
+NEW mail.message: hr_holidays.module_install_notification
+NEW mail.message.subtype: hr_holidays.mt_holidays_approved
+NEW mail.message.subtype: hr_holidays.mt_holidays_confirmed
+NEW mail.message.subtype: hr_holidays.mt_holidays_refused
+### -> New messages from chatter: Nothing to do
+
+NEW workflow.transition: hr_holidays.holiday_confirm2refuse
+NEW workflow.transition: hr_holidays.holiday_confirm2validate
+NEW workflow.transition: hr_holidays.holiday_confirm2validate1
+NEW workflow.transition: hr_holidays.holiday_draft2confirm
+NEW workflow.transition: hr_holidays.holiday_validate1_refuse
+NEW workflow.transition: hr_holidays.holiday_validate1_validate
+NEW workflow.transition: hr_holidays.holiday_validate2refuse
+DEL workflow.transition: hr_holidays.t1
+DEL workflow.transition: hr_holidays.t11
+DEL workflow.transition: hr_holidays.t2
+DEL workflow.transition: hr_holidays.t3
+DEL workflow.transition: hr_holidays.t4
+DEL workflow.transition: hr_holidays.t8
+### -> New conditions for jump between activities: Nothing to do
 
=== added file 'hr_holidays/migrations/7.0.1.5/pre-migration.py'
--- hr_holidays/migrations/7.0.1.5/pre-migration.py	1970-01-01 00:00:00 +0000
+++ hr_holidays/migrations/7.0.1.5/pre-migration.py	2014-03-27 18:51:21 +0000
@@ -0,0 +1,32 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This migration script copyright (C) 2014
+#                    Pedro M. Baeza ([e-mail])
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+from openupgrade import openupgrade
+
+column_renames = {
+    'hr_holidays': [
+        ('case_id', 'meeting_id'),
+    ]
+}
+
[e-mail]()
+def migrate(cr, version):
+    openupgrade.rename_columns(cr, column_renames)
 
=== added file 'hr_holidays/migrations/7.0.1.5/user_notes.txt'
--- hr_holidays/migrations/7.0.1.5/user_notes.txt	1970-01-01 00:00:00 +0000
+++ hr_holidays/migrations/7.0.1.5/user_notes.txt	2014-03-27 18:51:21 +0000
@@ -0,0 +1,3 @@
+*******************************************************************************
+1/ Optional meeting types that can be configured on leave types are reset 
+   during the upgrade and may need to be reconfigured.