Code review comment for lp:~pedro.baeza/ocb-addons/7.0-bug-1253701

Yes, I do believe you should keep it in the noupdate section. I understand that this means that the behaviour is not adapted automatically, but that is a generic problem with fixes in 'noupdate' data and the use of 'noupdate' data is relatively undisputed AFAIK.

Your solution is problematic because it will overwrite the rule with every module update from now on. Now I ccan think of a technical solution to that. In a project that was under our own control, I would suggest something like the following: increase the module version number and create a migration script that checks the value of the existing rule, then overwrite the value of the existing rule if it was unmodified wrt. the previous version. Else, if the rule was customized, log a verbose message.

As we are torn between following official OpenERP on one side, and trying to fix what we think is broken on the other side I can't say if it would be a good idea to introduce such a policy for OCB to deal with changes in noupdate data. Note that it would be inconsistent if we would only do it for OCB specific changes, because fixes in upstream code in 'noupdate' data would not follow this policy. We would have to track such changes to inject the update mechanism and I don't think that is going to happen.