Code review comment for lp:~pbeaman/akiban-server/direct-updates-2

Revision history for this message
Mike McMahon (mmcm) wrote :

It seems that all AbstractDirectObject really wants is a ServerJavaValues. So perhaps it would be simplest to give that out via JDBCResultSet.unwrap(). The other method, DirectResultSet.hasRow(), only serves to change an error message from "Past end" to "No more rows." This would eliminate a lot of forward knowledge of Direct.

It would then seem perfectly reasonable for ServerJavaValues (or a related interface) to have a method to "freeze" values for the purpose of copy. This could be unimplemented or a noop for most implementers and do what's needed for JDBCResultSet.

« Back to merge proposal