Code review comment for lp:~pbeaman/akiban-persistit/fix_1018526_temp_trees_in_journal

Revision history for this message
Peter Beaman (pbeaman) wrote :

Added code to detect IT records that refer to temporary volumes during recovery. Such trees are not restored into the handleToTreeMap and treeToHandleMap collections, so that when the journal next rolls over, the recorded tree map will contain only permanent trees and volumes. This logic will fix up existing systems.

Once we have had this version in the field on all sites we can then remove the cleanup code.

Note that from the information in the journal, the detection of a temporary volume is somewhat ad hoc. It is known by the conjunction of two things:

id value is 12345 (for no very good reason temporary volumes have all been marked with that ID number)
name ends with "_temporary_volume"

We feel it is unlikely there are any non-temporary volumes that have these two conditions at this time. However, eventually the detection code should be removed since it is less than perfectly precise.

review: Needs Resubmitting

« Back to merge proposal