Code review comment for lp:~pbeaman/akiban-persistit/fix-1157809-aioobe-on-append-key-segment

Revision history for this message
Peter Beaman (pbeaman) wrote :

Found some new problems and pushed back to Needs Review. Basically, the new KeyTest1#testKeyTooLong does not loop correctly and does not actually test all object values in the TEST_OBJECTS array. In particular, the method Key#appendString did not handle AIOOBE, and that's the one we are more concerned about.

« Back to merge proposal