I took some care to verify that the places that don't restore the value of _size also don't change it.
On Wed, Mar 20, 2013 at 2:03 PM, Nathan Williams <email address hidden>wrote:
> Review: Needs Information > > We should always restore _size in the even of an error, right? There are a > handful of places that don't do that, such as append(boolean). Perhaps > adding the size to restore to the new tooLong() helper method would enforce > that nicely. > > Otherwise seems simple enough. > -- > > https://code.launchpad.net/~pbeaman/akiban-persistit/fix-1157809-aioobe-on-append-key-segment/+merge/154422 > You are the owner of > lp:~pbeaman/akiban-persistit/fix-1157809-aioobe-on-append-key-segment. >
« Back to merge proposal
I took some care to verify that the places that don't restore the value of
_size also don't change it.
On Wed, Mar 20, 2013 at 2:03 PM, Nathan Williams <email address hidden>wrote:
> Review: Needs Information /code.launchpad .net/~pbeaman/ akiban- persistit/ fix-1157809- aioobe- on-append- key-segment/ +merge/ 154422
>
> We should always restore _size in the even of an error, right? There are a
> handful of places that don't do that, such as append(boolean). Perhaps
> adding the size to restore to the new tooLong() helper method would enforce
> that nicely.
>
> Otherwise seems simple enough.
> --
>
> https:/
> You are the owner of
> lp:~pbeaman/akiban-persistit/fix-1157809-aioobe-on-append-key-segment.
>