Code review comment for lp:~pbeaman/akiban-persistit/fix-1157809-aioobe-on-append-key-segment

Revision history for this message
Nathan Williams (nwilliams) wrote :

We should always restore _size in the even of an error, right? There are a handful of places that don't do that, such as append(boolean). Perhaps adding the size to restore to the new tooLong() helper method would enforce that nicely.

Otherwise seems simple enough.

review: Needs Information

« Back to merge proposal