Code review comment for lp:~pbeaman/akiban-persistit/fix-1126868-lock-table-pruning

Revision history for this message
Nathan Williams (nwilliams) wrote :

Does pruneLockPages() really need to call updateActiveTransactionCache()? It already happens every 10ms and doing it synchronously seems unnecessary.

VolumeStorageT2 and L2 are 99% identical. Can we pull some of that out into a base class, particularly the non-trivial stuff like read and write page? The javadoc also wasn't changed for L2.

Otherwise looks fine.

review: Needs Fixing

« Back to merge proposal