Code review comment for lp:~pbeaman/akiban-persistit/fix-1073357-Value-getType

Revision history for this message
Nathan Williams (nwilliams) wrote :

Looks mostly fine.

What if valueCache() does not contain the object? I'm not terribly familiar with it, but it looks like that is filled lazily. For example, what about Value append(a), append(b), append(a), store, clear, fetch, skip, skip, getType?

review: Needs Information

« Back to merge proposal