Code review comment for lp:~pbeaman/akiban-persistit/fix-1073357-Value-getType
Revision history for this message
| Yuval Shavit (yshavit) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Cool. I don't feel I'm qualified to comment on the rest of the merge prop, though if you'd like me to I can take a stab at it.
One comment on the test, lines 676-7, I believe the original bug was when the two objects were == (not just equal). So maybe create a new Long and then insert it twice, rather than inserting two unique Longs?