Code review comment for lp:~pbeaman/akiban-persistit/eclipse-canonical-format

Revision history for this message
Nathan Williams (nwilliams) wrote :

Looks to be minor conflicts in a couple files.

The eclipse-format.xml would fit nicely next to the other files in src/etc/, but that is pretty minor.

Other than that, I'm not terribly religious on any of the choices. However, this is the 2nd or 3rd time we've taken a big format hammer to the code. Can we use something like maven-eclipse-format-plugin in the process-sources section to do this mostly automatically? And hopefully prevent the need for large formatting in the future.

review: Needs Fixing

« Back to merge proposal