Code review comment for lp:~paulliu/unity8/unity8-fixgenericpreview

Revision history for this message
Michael Zanetti (mzanetti) wrote :

Videos:

What it is: http://wstaw.org/m/2013/09/26/plasma-desktopS30440.png
What it should be: http://wstaw.org/m/2013/09/26/plasma-desktopB30440.png

* It seems the text is too large. Also I guess it shouldn't wrap but elide.
* Lacks rating stars

Apps:
What it is: http://wstaw.org/m/2013/09/26/plasma-desktopC30440.png
What it should be: http://wstaw.org/m/2013/09/26/plasma-desktopy30440.png

* The title is double here. The one at the top should look exactly like the one at the bottom. The bottom one needs to go away

Overall some margins seem to be wrong. I.e. in the code the stuff is clipped 2 grid units from the bottom while the design spec doesn't do that clipping there.

review: Needs Fixing

« Back to merge proposal