Code review comment for lp:~paulliu/unity/phablet-add_unit_test

Revision history for this message
Michael Zanetti (mzanetti) wrote :

IMO it would be better to have only one OpenEffect element and use multiple test functions to change the gap and check if the others adapt accordingly.

This test only checks if the properties are initilized correctly but not if they also reflect changes during runtime.

review: Needs Fixing

« Back to merge proposal