67 + keywords: parse_string_list (details, JSON_FIELD_KEYWORDS), 68 + version: details.get_string_member(JSON_FIELD_VERSION), 69 + framework: parse_string_list (details, JSON_FIELD_FRAMEWORK)
Fix the spacing here please. The version and framework you added, seem to have tabs and are spaced further to the right, than the previous lines are.
58 + public string[] framework { get; construct; } 69 + framework: parse_string_list (details, JSON_FIELD_FRAMEWORK)
Why are you using this as a string list? The JSON for this seems to be a single string, not a list of strings.
338 +
Can you remove this new empty line you seem to have added?
172 + private string from_environ (string env_name, string default_value) { 177 + private string get_base_url () { 181 + private string get_review_url() {
There's no reason these need to be private. Rather, it would be a good idea to have them be public, and for there to be a few tests for them (especially to test from_environ's success and failure cases).
« Back to merge proposal
67 + keywords: parse_string_list (details, JSON_FIELD_ KEYWORDS) , get_string_ member( JSON_FIELD_ VERSION) , FRAMEWORK)
68 + version: details.
69 + framework: parse_string_list (details, JSON_FIELD_
Fix the spacing here please. The version and framework you added, seem to have tabs and are spaced further to the right, than the previous lines are.
58 + public string[] framework { get; construct; } FRAMEWORK)
69 + framework: parse_string_list (details, JSON_FIELD_
Why are you using this as a string list? The JSON for this seems to be a single string, not a list of strings.
338 +
Can you remove this new empty line you seem to have added?
172 + private string from_environ (string env_name, string default_value) {
177 + private string get_base_url () {
181 + private string get_review_url() {
There's no reason these need to be private. Rather, it would be a good idea to have them be public, and for there to be a few tests for them (especially to test from_environ's success and failure cases).