Code review comment for lp:~paulliu/unity-scope-click/showratings

Revision history for this message
Ying-Chun Liu (paulliu) wrote :

> 98 + return get_base_url() +
> "/api/1.0/reviews/filter/%s/%s/%s/%s/%s%s/page/%s/%s/";
>
> Please add a comment above this line, explaining which each %s is for exactly.
> Also, please switch to using the simpler URL, and avoid the "%s%s" combining
> the filter.packagename and filter.appname into a single part of the URL's
> path. We should be using "/api/1.0//reviews/filter/%s/%s/%s/%s/%s/" with
> "language, origin, distroseries, version, packagename" as the format values.
> The origin and packagename arguments should be the same here (using the
> package_name value from AppDetails), version should be version from
> AppDetails, and distroseries should be the "framework" value from AppDetails.
> We should also check that origin, distroseries, version, and packagename are
> not the default values of "any" or "", raising an error if they are, and not
> getting any reviews from the server in such a case.

seems to me that we currently don't have framework value in AppDetails. It is a private constant now.

« Back to merge proposal