Code review comment for lp:~paulliu/unity-scope-click/showratings

On Thu, Jan 2, 2014 at 4:55 PM, Rodney Dawes <email address hidden> wrote:
>> Correct, the origin should be "ubuntu" here, while the distroseries should be
>> "click" (there is no natty/precise/etc. for click packages - at least, that's
>> the decision that was made for exporting the apps from devportal [2]:
>>
>> [2] http://software-center.ubuntu.com/api/2.0/applications/en/ubuntu/click/
>>
>> I don't see why this unity-scope wouldn't just use the default for
>> ReviewFilter of ubuntu/click?
>
> Well, this doesn't make sense to me either. The origin isn't Ubuntu (ie, these packages aren't part of the Ubuntu archive, but are published by other individuals or organizations).

Hrm - true. So for existing reviews, the origin is the ppa identifier,
such as lp-ppa-commercial-ppa-uploaders-uberwriter.

For click packages, we have a packagename which includes an 'origin'
of sorts, like:

com.ubuntu.developer.victorsemyonov.mymaps

So I wonder if it'd make sense to use:

origin: com.ubuntu.developer.victorsemyonov
packagename: mymaps

in that case? Let me know, as I'll need to update the server (easy enough).

> So, I don't think we should be defaulting to anything, but instead getting some value from the details of the package, and using that as the origin. Maybe we need to add something to the package details endpoint of the click-package-index API to do that.

As above, the 'domain' seems to map 1:1 with the idea of origin?

> Also, I think the distroseries does need to be the actual distroseries here. But maybe we should be using the "click_framework" value from the package details here, rather than saucy/trusty/etc… ?

Yep, +1 to using the click_framework for the distroseries. I can get
an MP ready with those changes for the server. So, to check my
understanding with a summary:

You'll search/filter with origin: any, distroseries: ubuntu-sdk-13.10

You'll submit reviews with:
origin: com.ubuntu.developer.victorsemyonov
packagename: mymaps
distroseries: ubuntu-sdk-13.10

Will you need to search for click packages across frameworks? If so,
it'll need a bit more work to make that clean (as origin:any,
distroseries: any will give you not just click packages, but normal
packages also - a result of us just re-using the existing
infrastructure)., but if not, the above should be fine.

Let me know if you want to have a call about this.