This is still wrong. Why are you not using HTTPS here? Also, the _BASE_URL should only be "https://reviews.ubuntu.com/reviews" with "/api/1.0" added after. One shouldn't include the "/api/1.0" portion in the environment variable. If someone passes /api/2.0 for example, the app wouldn't handle it.
77 + const string REVIEWS_BASE_URL = "http:// reviews. ubuntu. com/reviews/ api/1.0";
86 + string from_environ (string env_name, string default_value) { get_variable (env_name); BASE_URL" , REVIEWS_BASE_URL);
87 + string env_value = Environment.
88 + return env_value != null ? env_value : default_value;
89 + }
90 +
91 + string get_base_url () {
92 + return from_environ ("U1_REVIEWS_
93 + }
This is still wrong. Why are you not using HTTPS here? Also, the _BASE_URL should only be "https:/ /reviews. ubuntu. com/reviews" with "/api/1.0" added after. One shouldn't include the "/api/1.0" portion in the environment variable. If someone passes /api/2.0 for example, the app wouldn't handle it.