Code review comment for lp:~paulliu/unity-mir/logout

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

If I understood it correctly, Q_SCRIPTABLE is used to mark the signals you want exposed on D-Bus. In which case, it makes no sense here.

=== modified file 'src/modules/Unity/Application/application_manager.h'
--- src/modules/Unity/Application/application_manager.h 2014-04-24 13:38:59 +0000
+++ src/modules/Unity/Application/application_manager.h 2014-04-24 18:45:21 +0000
@@ -132,7 +132,7 @@ public Q_SLOTS:

 Q_SIGNALS:
     void focusRequested(const QString &appId);
- Q_SCRIPTABLE void unityLogout();
+ void unityLogout();

 private Q_SLOTS:
     void screenshotUpdated();

review: Needs Fixing

« Back to merge proposal