Code review comment for lp:~paulliu/unity-mir/logout

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

If I understood it correctly the signals logoutRequested and logoutReady are used internally by unity8, right? So no need to expose them in D-Bus.

=== modified file 'src/modules/Unity/Application/dbusunitysessionservice.cpp'
--- src/modules/Unity/Application/dbusunitysessionservice.cpp 2014-04-24 18:27:05 +0000
+++ src/modules/Unity/Application/dbusunitysessionservice.cpp 2014-04-24 18:27:22 +0000
@@ -29,8 +29,7 @@ DBusUnitySessionService::DBusUnitySessio

     connection.registerService("com.canonical.Unity.Session");
     connection.registerObject("/com/canonical/Unity/Session", this,
- QDBusConnection::ExportAllSignals
- | QDBusConnection::ExportScriptableSlots
+ QDBusConnection::ExportScriptableSlots
             | QDBusConnection::ExportScriptableInvokables);
 }

=== modified file 'src/modules/Unity/Application/dbusunitysessionservice.h'
--- src/modules/Unity/Application/dbusunitysessionservice.h 2014-04-24 17:45:48 +0000
+++ src/modules/Unity/Application/dbusunitysessionservice.h 2014-04-24 18:28:40 +0000
@@ -47,7 +47,7 @@ Q_SIGNALS:
      * @param have_inhibitors if there are any special running applications
      * which inhibit the logout.
      */
- Q_SCRIPTABLE void logoutRequested(bool have_inhibitors);
+ void logoutRequested(bool have_inhibitors);

     /**
      * logoutReady signal

review: Needs Fixing

« Back to merge proposal