share-app

Merge lp:~paulliu/share-app/desktop_file_tweak into lp:share-app

  1. desktop_file_tweak
  2. Merge into trunk
Proposed by Ying-Chun Liu
Status: Merged
Approved by: Michał Sawicz
Approved revision: 44
Merged at revision: 43
Proposed branch: lp:~paulliu/share-app/desktop_file_tweak
Merge into: lp:share-app
Diff against target: 26 lines (+11/-0)
2 files modified
debian/changelog (+8/-0)
share-app.desktop (+3/-0)
To merge this branch: bzr merge lp:~paulliu/share-app/desktop_file_tweak
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Michał Sawicz Approve
Bill Filler (community) Approve
Review via email: mp+156560@code.launchpad.net

Commit message

Add NoDisplay=true into share-app.desktop.

Description of the change

Add NoDisplay=true into share-app.desktop.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:42
http://jenkins.qa.ubuntu.com/job/share-app-ci/8/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-ci/8
        deb: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-ci/8/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-i386-ci/8
    FAILURE: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-ci/8/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-i386-ci/8
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/540

Click here to trigger a rebuild:
http://s-jenkins:8080/job/share-app-ci/8/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Martin Mrazik (mrazik) wrote :

I fixed the armhf issue.

Revision history for this message
Bill Filler (bfiller) wrote :

approve

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:43
http://jenkins.qa.ubuntu.com/job/share-app-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-ci/9/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-i386-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-ci/9/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-i386-ci/9
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/554

Click here to trigger a rebuild:
http://s-jenkins:8080/job/share-app-ci/9/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/share-app-autolanding/7/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-autolanding/7
        deb: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-autolanding/7/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-i386-autolanding/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-autolanding/7
        deb: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-autolanding/7/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-i386-autolanding/7
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/565

review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

This needs a "X-Ubuntu-Touch=true", too.

review: Needs Fixing
Revision history for this message
Michał Sawicz (saviq) wrote :

And X-Ubuntu-StageHint=SideStage

review: Needs Fixing
Revision history for this message
Michał Sawicz (saviq) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:44
http://jenkins.qa.ubuntu.com/job/share-app-ci/10/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-ci/10
        deb: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-ci/10/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-i386-ci/10
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-ci/10
        deb: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-ci/10/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-i386-ci/10
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/597

Click here to trigger a rebuild:
http://s-jenkins:8080/job/share-app-ci/10/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/share-app-autolanding/8/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-autolanding/8
        deb: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-autolanding/8/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-i386-autolanding/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-autolanding/8
        deb: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-autolanding/8/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-i386-autolanding/8
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/600

review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

I'm not sure what happens here, but it's unrelated to the changes in this MP :/

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:44
http://jenkins.qa.ubuntu.com/job/share-app-ci/11/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-ci/11/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-i386-ci/11
    FAILURE: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-ci/11/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-i386-ci/11
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/605

Click here to trigger a rebuild:
http://s-jenkins:8080/job/share-app-ci/11/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:44
http://jenkins.qa.ubuntu.com/job/share-app-ci/12/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-ci/12
        deb: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-ci/12/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-i386-ci/12
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-ci/12
        deb: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-ci/12/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-i386-ci/12
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/606

Click here to trigger a rebuild:
http://s-jenkins:8080/job/share-app-ci/12/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

The two tests simply don't want to pass, we need help with this :/

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:44
http://jenkins.qa.ubuntu.com/job/share-app-ci/15/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-ci/15
        deb: http://jenkins.qa.ubuntu.com/job/share-app-quantal-armhf-ci/15/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-quantal-i386-ci/15
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-ci/15
        deb: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-ci/15/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-i386-ci/15
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/629

Click here to trigger a rebuild:
http://s-jenkins:8080/job/share-app-ci/15/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-03-23 20:26:48 +0000
+++ debian/changelog 2013-04-03 14:36:30 +0000
@@ -1,3 +1,11 @@
1share-app (0.11) quantal; urgency=low
2
3 * Add NoDisplay=true into share-app.desktop.
4 * Add X-Ubuntu-Touch=true and X-Ubuntu-StageHint=SideStage into
5 share-app.desktop.
6
7 -- Ying-Chun Liu (PaulLiu) <paul.liu@canonical.com> Wed, 03 Apr 2013 22:31:52 +0800
8
1share-app (0.10) quantal; urgency=low9share-app (0.10) quantal; urgency=low
210
3 * Update runtime dependencies:11 * Update runtime dependencies:
412
=== modified file 'share-app.desktop'
--- share-app.desktop 2012-12-10 16:11:33 +0000
+++ share-app.desktop 2013-04-03 14:36:30 +0000
@@ -6,3 +6,6 @@
6Exec=share-app %u6Exec=share-app %u
7Terminal=false7Terminal=false
8Icon=share-app8Icon=share-app
9NoDisplay=true
10X-Ubuntu-Touch=true
11X-Ubuntu-StageHint=SideStage

Subscribers

People subscribed via source and target branches