Sorry this has taken so long to land; I'm going through some old loggerhead merge proposals now. I was about to merge this since it's approved, but I thought the change to the _approximatedate function seemed odd, and possibly unintentional. Was there a reason you removed support for dates in the future from this? I think they can occur if the committer's clock is wrong, and in any case it shouldn't hurt to retain support for them.
Sorry this has taken so long to land; I'm going through some old loggerhead merge proposals now. I was about to merge this since it's approved, but I thought the change to the _approximatedate function seemed odd, and possibly unintentional. Was there a reason you removed support for dates in the future from this? I think they can occur if the committer's clock is wrong, and in any case it shouldn't hurt to retain support for them.